Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small fixes #7

Merged
merged 15 commits into from
Jun 4, 2024
Merged

fix: small fixes #7

merged 15 commits into from
Jun 4, 2024

Conversation

alex-reiff
Copy link
Contributor

Description

fixed issue 1: https://github.ibm.com/GoldenEye/issues/issues/7055

fixed issue 2: the resetState pop-up close button now works.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@alex-reiff alex-reiff requested a review from akocbek as a code owner April 29, 2024 17:40
@alex-reiff
Copy link
Contributor Author

/run pipeline

@alex-reiff
Copy link
Contributor Author

/run pipeline

@alex-reiff
Copy link
Contributor Author

/run pipeline

@alex-reiff
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor

/run pipeline

@toddgiguere toddgiguere merged commit 4a29bba into main Jun 4, 2024
2 checks passed
@toddgiguere toddgiguere deleted the fix branch June 4, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants