Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:exposed visibility value for the provider in the DA #334

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

Aditya-ranjan-16
Copy link
Contributor

Description

exposed visibility value for the provider in the DA , with default value set to "private"

Git issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

exposes visibility value for the provider in the DA

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aditya-ranjan-16
Copy link
Contributor Author

added a new variable hence skipping upgrade test

Screenshot 2024-11-22 at 5 17 30 AM

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

Aditya-ranjan-16 commented Nov 22, 2024

reverted back to previous commit as added the skip upgrade test empty commit twice by mistake apologies!

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

1 similar comment
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

Copy link
Member

@Aashiq-J Aashiq-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aashiq-J Aashiq-J merged commit 98cd367 into main Nov 26, 2024
2 checks passed
@Aashiq-J Aashiq-J deleted the provider_visibility branch November 26, 2024 09:23
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[terraform-ibm-event-notifications] Expose provider visibility in the DA
3 participants