Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added basic and complete example #52

Merged
merged 32 commits into from
Nov 10, 2023
Merged

feat: added basic and complete example #52

merged 32 commits into from
Nov 10, 2023

Conversation

Ak-sky
Copy link
Member

@Ak-sky Ak-sky commented Oct 13, 2023

Description

Starting with a basic EN module that simply deploys the service. Added basic and complete example.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Initial module release.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Ak-sky Ak-sky changed the title [DoNotMerge]feat: added basic example feat: added basic and complete example Oct 18, 2023
@Ak-sky Ak-sky requested a review from jojustin October 18, 2023 20:39
@Ak-sky Ak-sky marked this pull request as ready for review October 18, 2023 20:39
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Also the usage is missing from main readme.

I'm reading this in the docs "BYOK and KYOK capabilities are supported only for Event Notifications Standard plan." so perhaps add validation for this

examples/basic/main.tf Outdated Show resolved Hide resolved
examples/basic/variables.tf Outdated Show resolved Hide resolved
examples/complete/main.tf Outdated Show resolved Hide resolved
examples/complete/variables.tf Outdated Show resolved Hide resolved
examples/complete/variables.tf Show resolved Hide resolved
tests/pr_test.go Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@Ak-sky Ak-sky changed the title feat: added basic and complete example [DONOTMERGE]feat: added basic and complete example Oct 24, 2023
@Ak-sky Ak-sky marked this pull request as draft October 24, 2023 16:37
@Ak-sky Ak-sky marked this pull request as ready for review November 2, 2023 15:13
@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 2, 2023

/run pipeline

@Ak-sky Ak-sky changed the title [DONOTMERGE]feat: added basic and complete example feat: added basic and complete example Nov 2, 2023
@Ak-sky Ak-sky requested a review from ocofaigh November 2, 2023 15:14
@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 3, 2023

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 3, 2023

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 7, 2023

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 7, 2023

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 7, 2023

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 7, 2023

Test is failing because whichever the region is being selected randomly from the test here, it is not using the same region for the resources here.

Here TF apply is with eu-de region.

TestRunCompleteExample 2023-11-07T11:45:11Z logger.go:66: Running command terraform with args [apply -input=false -auto-approve -var resource_group=geretain-test-event-notifications -var resource_tags=[] -var prefix=event-notification-complete-ohxuum -var region=eu-de -lock=false]

but en resources are created in other region, hence data block to fetch integrations are failing.

image

@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 8, 2023

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 8, 2023

PR is now failing with below- looking into this.

TestRunCompleteExample 2023-11-08T07:11:33Z logger.go:66: │ "errors": [
TestRunCompleteExample 2023-11-08T07:11:33Z logger.go:66: │ {
TestRunCompleteExample 2023-11-08T07:11:33Z logger.go:66: │ "code": "SERVICE_TO_SERVICE_UNAUTHORIZED_ERROR",
TestRunCompleteExample 2023-11-08T07:11:33Z logger.go:66: │ "message": "Unauthorized, service to service authorization is not enabled.",
TestRunCompleteExample 2023-11-08T07:11:33Z logger.go:66: │ "more_info": "https://cloud.ibm.com/apidocs/event-notifications"
TestRunCompleteExample 2023-11-08T07:11:33Z logger.go:66: │ }
TestRunCompleteExample 2023-11-08T07:11:33Z logger.go:66: │ ],

@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 8, 2023

/run pipeline

@Ak-sky Ak-sky requested a review from ocofaigh November 8, 2023 09:41
examples/complete/main.tf Outdated Show resolved Hide resolved
@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 9, 2023

/run pipeline

@Ak-sky Ak-sky requested a review from ocofaigh November 9, 2023 15:41
examples/complete/main.tf Outdated Show resolved Hide resolved
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 9, 2023

/run pipeline

@Ak-sky Ak-sky requested a review from ocofaigh November 9, 2023 17:27
@ocofaigh ocofaigh merged commit d2b853d into main Nov 10, 2023
@ocofaigh ocofaigh deleted the basic branch November 10, 2023 09:55
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Ak-sky pushed a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants