-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added basic and complete example #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Also the usage is missing from main readme.
I'm reading this in the docs "BYOK and KYOK capabilities are supported only for Event Notifications Standard plan." so perhaps add validation for this
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
Test is failing because whichever the region is being selected randomly from the test here, it is not using the same region for the resources here. Here TF apply is with
but en resources are created in other region, hence data block to fetch integrations are failing. |
/run pipeline |
PR is now failing with below- looking into this.
|
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
/run pipeline |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Co-authored-by: Renovate Bot <[email protected]>
Description
Starting with a basic EN module that simply deploys the service. Added basic and complete example.
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Initial module release.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers