Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor:update the prefix logic in DA #565

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

arya-girish-k
Copy link

@arya-girish-k arya-girish-k commented Jan 13, 2025

Description

Refactored the code logic for prefix variable by adding default value for prefix and marked as required in catalog manifest.Also allowed prefix to be "" (empty string) for advanced users.
#11959

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Add the default value for prefix variable and mark as required in catalog manifest. Also allowed prefix to be "" (empty string ).The addition of a default value for the prefix variable has caused a failure in the TestRunStandardUpgradeSolution. However, if users remove the prefix, it will not result in a breaking change.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@arya-girish-k
Copy link
Author

/run pipeline

@arya-girish-k arya-girish-k self-assigned this Jan 15, 2025
@arya-girish-k
Copy link
Author

/run pipeline

@arya-girish-k
Copy link
Author

@arya-girish-k
Copy link
Author

The TestRunStandardUpgradeSolution is failing due to the addition of a default value for the prefix variable.
https://github.com/terraform-ibm-modules/terraform-ibm-icd-postgresql/actions/runs/12789666604/job/35653920290#step:7:2292

As per the test terraform will execute the following actions:

  • Update the resource_group, kms_policy, and postgresql_db resources.

  • Destroy the existing kms_key, kms_key_ring, and kms_key_policy resources.

  • Create new instances of kms_key, kms_key_ring, and kms_key_policy resources.

Since removing the prefix won't result in a breaking change for the user, So as per the discussion it is fine to skip the upgrade test in this scenario.

@arya-girish-k
Copy link
Author

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant