Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefixing SLZ test resource groups #7

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

vbontempi
Copy link
Member

@vbontempi vbontempi commented Feb 16, 2024

prefixing SLZ test resource groups

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

prefixed SLZ test resource groups

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

made test resource groups to be prefixed
@vbontempi
Copy link
Member Author

/run pipeline

@ocofaigh
Copy link
Member

Why do you need a patch release for this? Its just an update to the test

@vbontempi
Copy link
Member Author

Why do you need a patch release for this? Its just an update to the test
fixed

@ocofaigh ocofaigh merged commit f532903 into main Feb 16, 2024
2 checks passed
@ocofaigh ocofaigh deleted the vbontempi-patch-1 branch February 16, 2024 18:01
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants