Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updating TestRunExistingResourcesInstances to run in schematics. #239

Merged
merged 8 commits into from
Jan 3, 2025
Merged

fix: Updating TestRunExistingResourcesInstances to run in schematics. #239

merged 8 commits into from
Jan 3, 2025

Conversation

aatreyee2506
Copy link
Contributor

@aatreyee2506 aatreyee2506 commented Dec 26, 2024 •
edited by iamar7
Loading

Description

Updated TestRunExistingResourcesInstances function to run in schematics .
Git issue

Resolves: #227

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Updated TestRunExistingResourcesInstances function to run in schematics .

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506
Copy link
Contributor Author

/run pipeline

iamar7
iamar7 requested changes Dec 27, 2024
View reviewed changes
tests/pr_test.go Outdated Show resolved Hide resolved
tests/pr_test.go Outdated Show resolved Hide resolved
aatreyee2506 and others added 2 commits December 27, 2024 20:10
@aatreyee2506 @iamar7
Update tests/pr_test.go
d4710e9 
Co-authored-by: Md Anam Raihan <[email protected]>
@aatreyee2506 @iamar7
Update tests/pr_test.go
189c70e 
Co-authored-by: Md Anam Raihan <[email protected]>
@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506 aatreyee2506 marked this pull request as ready for review December 28, 2024 03:08
@aatreyee2506
Copy link
Contributor Author

/run pipeline

iamar7
iamar7 reviewed Jan 1, 2025
View reviewed changes
tests/pr_test.go Outdated Show resolved Hide resolved
iamar7
iamar7 reviewed Jan 1, 2025
View reviewed changes
tests/pr_test.go Outdated Show resolved Hide resolved
iamar7
iamar7 reviewed Jan 1, 2025
View reviewed changes
tests/pr_test.go Outdated Show resolved Hide resolved
iamar7
iamar7 reviewed Jan 1, 2025
View reviewed changes
tests/pr_test.go Outdated Show resolved Hide resolved
iamar7
iamar7 reviewed Jan 1, 2025
View reviewed changes
tests/pr_test.go Outdated Show resolved Hide resolved
@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506 aatreyee2506 requested a review from iamar7 January 1, 2025 12:28
iamar7
iamar7 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@iamar7 iamar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aashiq-J Aashiq-J merged commit e8ae9d8 into main Jan 3, 2025
2 checks passed
@Aashiq-J Aashiq-J deleted the issue_11799 branch January 3, 2025 06:00
@iamar7 iamar7 mentioned this pull request Jan 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamar7 iamar7 iamar7 approved these changes

@maheshwarishikha maheshwarishikha Awaiting requested review from maheshwarishikha maheshwarishikha is a code owner

Assignees

@aatreyee2506 aatreyee2506

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update TestRunExistingResourcesInstances to run in schematics
3 participants
@aatreyee2506 @iamar7 @Aashiq-J