Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add cra ignore rules #637

Merged
merged 1 commit into from
Oct 2, 2023
Merged

ci: add cra ignore rules #637

merged 1 commit into from
Oct 2, 2023

Conversation

surajsbharadwaj
Copy link
Contributor

Description

ignore rule in cra scan

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • When merging, use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

@surajsbharadwaj
Copy link
Contributor Author

/run pipeline

@surajsbharadwaj surajsbharadwaj merged commit 9dbdfea into main Oct 2, 2023
@surajsbharadwaj surajsbharadwaj deleted the ignore_cra_rules branch October 2, 2023 11:22
stafaniasaju
stafaniasaju reviewed Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@stafaniasaju stafaniasaju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stafaniasaju stafaniasaju stafaniasaju left review comments

@ocofaigh ocofaigh ocofaigh approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@surajsbharadwaj @terraform-ibm-modules-ops @ocofaigh @stafaniasaju