Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "dependency_version_2": true #743

Closed
wants to merge 1 commit into from
Closed

fix: "dependency_version_2": true #743

wants to merge 1 commit into from

Conversation

ocofaigh
Copy link
Member

@ocofaigh ocofaigh commented Dec 6, 2024

Description

Catalog team are recommending to set "dependency_version_2": true. The UI will handle the way it displays dependencies better when enabled

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh
Copy link
Member Author

ocofaigh commented Dec 6, 2024

/run pipeline

@ocofaigh
Copy link
Member Author

ocofaigh commented Dec 6, 2024

@surajsbharadwaj I'll let you handling merging, as I don't know if you wan't to generate a new release now or not

@ocofaigh
Copy link
Member Author

ocofaigh commented Dec 6, 2024

@surajsbharadwaj maybe hold off on merge here - I found an issue. Will get back to you.

@ocofaigh ocofaigh marked this pull request as draft December 6, 2024 13:29
@surajsbharadwaj
Copy link
Contributor

@ocofaigh do we have a reference to ibm_catatog.json file somewhere ? Like schema and stuff to know complete configuration support. ? Would be good to know

@ocofaigh
Copy link
Member Author

ocofaigh commented Dec 6, 2024

Closing this for now - the catalog team need to provide migration support to move to this: https://github.ibm.com/ibmcloud/content-catalog/issues/5207

@ocofaigh ocofaigh closed this Dec 6, 2024
@ocofaigh ocofaigh deleted the ocofaigh-patch-1 branch December 6, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants