feat: catalog onboarding #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
updated offering ID |
ocofaigh
approved these changes
Feb 8, 2024
vburckhardt
pushed a commit
that referenced
this pull request
Feb 15, 2024
* feat: first draft * feat: second draft * feat: added script to retrieve and output sample app url * feat: da ibm catalog (#1) Co-authored-by: Rajat Agrawal <[email protected]> * feat: added example and test and extension * feat: added sleep before reading sampleapp URL * feat: adjusted prtest conf * feat: removed subnets from basic test output * fixed: moved basic example to complete folder SKIP UPGRADE TEST * fix: removed pub gw from complete test cluster * feat: added back LBs in complete test * fix: test to validate SCC scan * feat: reference architecture (#5) * feat: added cleanup hooks and addressed PR comments * fix: fixed description on GH setting * feat: set default images path and version * fix: PR comments * test: extension tests (#6) * fix: addressing comments of PR * Fix extension tests (#7) * catalog onboarding (#10) * fix: making SLZ test with public nw access * fix: fixed override json * fix: reduced override json to vpc settings only * fix: fixed override json * fix: setting custom override json * fix: setting reduced override json * fix: setting custom override json * fix: setting custom override json * feat: testing config * fix: some cleanup * fix: fixed region description in extension * fix: updated readme.md * fix: testing sleep to have RBAC synch * fix: testing kubeconfig in extension * fix: testing kubeconfig in extension * fix: addressing PR comments * fix: remove internal issue and increased sleep to 5m * fix: addressed PR comments * fix: fixed error in log format * fix: fixed chart desc * fix: addressed PR comments * Update settings.yml sync description with readme --------- Co-authored-by: rajatagarwal-ibm <[email protected]> Co-authored-by: Rajat Agrawal <[email protected]> Co-authored-by: Allen Dean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers