First release cleanup

[vbontempi]

Description

First part of the cleanup task from #8

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

• Scaled down complete test cluster
• reviewed WebSphere Liberty naming
• Removed commented code
• Fixed kubeconfig path for datasource
• Removed default region for extension
• Prefixed sample app URL with https:// to make it clickable when deployed through DA
• Made resource groups names prefixed with random prefix with SLZ test override json

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[vbontempi]

@SirSpidey I think I addressed all your comments and questions and pushed the changes

[vbontempi]

/run pipeline

[SirSpidey]

I'm fine with leaving the kubeconfig readme, I just don't understand what it does and why we would leave a link to an internal issue.

[vbontempi]

I'm fine with leaving the kubeconfig readme, I just don't understand what it does and why we would leave a link to an internal issue.

right, the internal link is to be removed, done

[vbontempi]

/run pipeline

[rajatagarwal-ibm]

Here scripts/confirm-wsloperator-operational.sh:

• -o wide flag doesn't work in the following command:

kubectl describe Subscription ibm-websphere-liberty -n "${namespace}" -o wide

Result of running the above command:

10135 ± kubectl describe Subscription ibm-websphere-liberty -n openshift-operators -o wide                                                                                                                                       
error: unknown shorthand flag: 'o' in -o
See 'kubectl describe --help' for usage.

[rajatagarwal-ibm]

Need to update readme for the examples/complete/README.md.

• Not creating 3 subnets anymore.
• Not creating 3 worker pools anymore.

[rajatagarwal-ibm]

Should update examples/complete/main.tf

• If we are not consuming 3 subnets, probably we can create only 1 subnet. https://github.com/terraform-ibm-modules/terraform-ibm-websphere-liberty-operator/blob/main/examples/complete/main.tf#L35
• If you agree to create 1 subnet, we should create only 1 public gateway as well. https://github.com/terraform-ibm-modules/terraform-ibm-websphere-liberty-operator/blob/main/examples/complete/main.tf#L26

[rajatagarwal-ibm]

The title is wrong in this readme extensions/landing-zone/README.md

[vbontempi]

Need to update readme for the examples/complete/README.md.

* Not creating 3 subnets anymore.

* Not creating 3 worker pools anymore.

2 workers are the min for OCP. Reduced to 2.

All the other comments are addressed and pushed, please review

[vbontempi]

/run pipeline

[SirSpidey]

a few more small suggestions

[vbontempi]

a few more small suggestions

thank you for the suggestions, committed all of them, could you please review?

[vbontempi]

/run pipeline

[SirSpidey]

also updated the settings.yml description in this PR.

[rajatagarwal-ibm]

/run pipeline

[ocofaigh]

@vburckhardt @vbontempi @rajatagarwal-ibm The PR was not merged with a commit message that will generate a release. If you need a release like you indicated in the PR description, a new PR needs to be created and merged with correct prefix

[terraform-ibm-modules-ops]

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

• GitHub release
• v1.0.1

Your semantic-release bot 📦🚀