Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two variables for one function #26

Open
Dok-dev opened this issue Nov 3, 2023 · 2 comments
Open

Two variables for one function #26

Dok-dev opened this issue Nov 3, 2023 · 2 comments

Comments

@Dok-dev
Copy link

Dok-dev commented Nov 3, 2023

Two variables are used to select the CNI plugin. And how not to install the plugin at all is also not obvious:

variable "network_policy_provider" {
description = "Network policy provider for Kubernetes cluster"
type = string
default = "CALICO"
}
variable "enable_cilium_policy" {
description = "Flag for enabling or disabling Cilium CNI."
type = bool
default = false
}

I used a solution with a single variable "network_policy_provider" for all three cases. Do you think it is appropriate to make a pull request for this?

@romati88
Copy link
Contributor

We use Calico only for network policy functionality (if Cilium isn't used) and not as CNI. So Cilium CNI is called tunnel mode in managed k8s and must be separated variable. You can turn of NP at all with :

network_policy_provider = ""
enable_cilium_policy=false

@Dok-dev
Copy link
Author

Dok-dev commented Feb 10, 2024

Thanks for quoting the documentation, although I didn't ask anything. I think everyone here understands how it works. The problem is the illogical switching of network plug-ins, which complicates automation when using the module. We use a different solution to switch network plug-ins of a single variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants