Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies.repos #411

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

Levi-Armstrong
Copy link
Contributor

No description provided.

@Levi-Armstrong
Copy link
Contributor Author

@marip8 I think your changes to CI has broken the repos CI builds. I am trying to get a release out today do you know how to fix this?

'init' returned with code '0' after 0 min 7 sec
UNDERLAY '/root/tesseract-robotics/tesseract_target_ws/install' does not contain a setup.bash

@marip8
Copy link
Contributor

marip8 commented Nov 8, 2023

The /opt directory in the built docker image has been cleared, so none of the build artifacts exist in it. I think it may be something with the AFTER_SCRIPT step that tries to remove the build directory. I'm going to run locally now to figure this out

@Levi-Armstrong
Copy link
Contributor Author

I reran it and it now shows this error message.

'init' returned with code '0' after 0 min 6 sec
UNDERLAY '${BASEDIR}/tesseract-robotics/tesseract_target_ws/install' does not contain a setup.bash

@marip8
Copy link
Contributor

marip8 commented Nov 8, 2023

Running it locally (for tesseract, not tesseract_planning) shows that things build in the /opt directory correctly and the unit tests run, but for some reason none of that gets saved into the docker image when it is committed. That's why this repo can't find /opt/tesseract-robotics/tesseract_target_ws because it doesn't actually exist in the docker image

@marip8
Copy link
Contributor

marip8 commented Nov 8, 2023

Per ICI:

BASEDIR (default: $HOME): Base directory in which the upstream, target, and downstream workspaces will be built. Note: this directory is bind-mounted, so it can be read by the CI service, but its contents will not persist in the image configured by DOCKER_COMMIT

For some reason this is not true when BASEDIR=/root because the build artifacts remain in /root, but this does seem to be true with BASEDIR=/opt. I'm running a test now with BASEDIR=/home to see if the same thing happens. If it does, I think the solution would be to set BASEDIR=/home and use AFTER_SCRIPT to copy the build artifacts in the install directories to /opt

@marip8
Copy link
Contributor

marip8 commented Nov 9, 2023

Re-running CI now that the tesseract docker images have been regenerated

@marip8
Copy link
Contributor

marip8 commented Nov 10, 2023

I just pushed a 0.21.1 release to tesseract to regenerate the tagged docker images for the stable builds. We can re-run those failed jobs after that finishes

@Levi-Armstrong Levi-Armstrong merged commit 1ae1627 into tesseract-robotics:master Nov 10, 2023
10 checks passed
@Levi-Armstrong Levi-Armstrong deleted the update/Deps branch November 10, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants