From 914f1e55bcb3b10260788c3affb8426f77eb9036 Mon Sep 17 00:00:00 2001
From: Max Pfeiffer <max@maxpfeiffer.ch>
Date: Sun, 31 Mar 2024 00:23:39 +0100
Subject: [PATCH] fix: inconsistent test runs for community modules (#497)

- Fixed inconsistencies for community module test runs: using all
supported Python versions
- Pinned runner version (best practice)

fixes https://github.com/testcontainers/testcontainers-python/issues/482
---
 .github/workflows/ci-community.yml   | 6 +++---
 .github/workflows/ci-core.yml        | 3 +--
 .github/workflows/ci-lint.yml        | 2 +-
 .github/workflows/docs.yml           | 2 +-
 .github/workflows/pr-lint.yml        | 2 +-
 .github/workflows/release-please.yml | 4 ++--
 6 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml
index 9284463c..caebace0 100644
--- a/.github/workflows/ci-community.yml
+++ b/.github/workflows/ci-community.yml
@@ -14,7 +14,7 @@ on:
 
 jobs:
   track-modules:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: Checkout contents
         uses: actions/checkout@v4
@@ -38,14 +38,14 @@ jobs:
     outputs:
       changed_modules: ${{ steps.compute-changes.outputs.computed_modules }}
   test:
+    runs-on: ubuntu-22.04
     needs: [track-modules]
     if: ${{ needs.track-modules.outputs.changed_modules != '[]' }}
     strategy:
       fail-fast: false
       matrix:
-        python-version: [ "3.11" ]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
         module: ${{ fromJSON(needs.track-modules.outputs.changed_modules) }}
-    runs-on: ubuntu-latest
     steps:
       - name: Checkout contents
         uses: actions/checkout@v4
diff --git a/.github/workflows/ci-core.yml b/.github/workflows/ci-core.yml
index c39eb1ea..f794f98e 100644
--- a/.github/workflows/ci-core.yml
+++ b/.github/workflows/ci-core.yml
@@ -10,12 +10,11 @@ on:
 
 jobs:
   test:
+    runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
       matrix:
-        os: [ ubuntu ]
         python-version: ["3.9", "3.10", "3.11", "3.12"]
-    runs-on: ${{ matrix.os }}-latest
     steps:
       - uses: actions/checkout@v4
       - name: Set up Python
diff --git a/.github/workflows/ci-lint.yml b/.github/workflows/ci-lint.yml
index a02136ec..f9da3b40 100644
--- a/.github/workflows/ci-lint.yml
+++ b/.github/workflows/ci-lint.yml
@@ -10,7 +10,7 @@ on:
 
 jobs:
   python:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
       - name: Setup Env
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 1dfb6c71..e27c89ad 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -8,7 +8,7 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
       - name: Set up Python
diff --git a/.github/workflows/pr-lint.yml b/.github/workflows/pr-lint.yml
index b99c3074..84d80590 100644
--- a/.github/workflows/pr-lint.yml
+++ b/.github/workflows/pr-lint.yml
@@ -13,7 +13,7 @@ permissions:
 jobs:
   validate:
     name: validate-pull-request-title
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: validate pull request title
         uses: kontrolplane/pull-request-title-validator@ab2b54babb5337246f4b55cf8e0a1ecb0575e46d  #v1
diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml
index a5a9821a..9176c674 100644
--- a/.github/workflows/release-please.yml
+++ b/.github/workflows/release-please.yml
@@ -6,7 +6,7 @@ on:
 
 jobs:
   release:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     outputs:
       release_created: ${{ steps.track-release.outputs.release_created }}
     steps:
@@ -16,7 +16,7 @@ jobs:
           manifest-file: .github/.release-please-manifest.json
           config-file: .github/release-please-config.json
   publish:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     environment: release
     permissions:
       id-token: write