Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Develop strategy for testing Tethys with and without optional dependencies installed #1104

Open
swainn opened this issue Oct 11, 2024 · 0 comments

Comments

@swainn
Copy link
Member

swainn commented Oct 11, 2024

We currently build our test environment with all dependencies installed so that we can test all of the features in Tethys, even those with optional dependencies. I think we will still need to do this even after Tethys 5 is released so we can be assured that it still works with everything installed.

However, we currently don't test Tethys without the optional dependencies installed which leaves us vulnerable. This will be more of a risk in Tethys 5, so I think we should also run our test suite without all of the optional dependencies to be assured it works in that state.

I propose we run the tests twice, once with all dependencies, and once without optional dependencies. This will require us to annotate the tests somehow. Maybe an "optional_dependency" decorator that is a variation on "allowed to fail" that only allows fails under certain conditions? Like import errors or module not found errors? Starting this issue so we can discuss more.

@swainn swainn added this to the Version 5.0 milestone Oct 11, 2024
@swainn swainn self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant