Style: Clear Naming Convention for Variables

[jdsika]

Some auto formatting e.g. in batch_payer.py is very strange.

            number_future_payable_cycles = (
                int(
                    payment_address_balance
                    / (estimated_amount_to_pay * PAYMENT_ACCOUNT_SAFETY_MARGIN)
                )
                - 1
            )

[vkresch]

This is due to the default line length for black – 88 characters per line.
To increase the line length, we could use the --line-length flag.

$ black --line-length 92 .

Or we could make the variable names smaller but still keep it explicit e.g.:
payment_address_balance -> payment_balance

We could also think about how to reduce the indentation on the left side etc.

[jdsika]

ok, I think we leave this open to remind us to rename variables to a certain style in the future. I think modifying black regarding --line-length is not the trick. A clear naming convention is maybe better.

[ericlavoie]

This is due to the default line length for black – 88 characters per line. To increase the line length, we could use the --line-length flag.

$ black --line-length 92 .

Or we could make the variable names smaller but still keep it explicit e.g.: payment_address_balance -> payment_balance

We could also think about how to reduce the indentation on the left side etc.

The 88 is a limitation to be compatible with vt100 terminal. I prefer having it set at 99/100 88 is too short imo. Just my 0.02$