Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map renderings do not account for pixelshifted objects #102

Open
Amelia0010 opened this issue Mar 8, 2019 · 0 comments
Open

map renderings do not account for pixelshifted objects #102

Amelia0010 opened this issue Mar 8, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Amelia0010
Copy link

[17:32] Nich: @SpaceManiac If an object has pixel_y/x set to be outside of the tile, mapdiffbot's rendering doesn't expand the image appropriately. As an example, someone on yogs added a second red-alert-thingy to the bridge, both being on the wall to the AI upload, but they're outside of the rendering's range
[17:32] Nich:
image

[17:32] Nich: with my crudely drawn red dots being where they are now
[17:32] Nich: https://github.com/yogstation13/Yogstation-TG/pull/4702/checks?check_run_id=73845208
[19:14] SpaceManiac: I'd have to negotiate w/ Cyberboss about this. My tools report the changed tiles w/o pixel_xy data and MDB calculates the rectangle surrounding them and passes that as the bounding box of the render
[21:39] Nich: yeah I wasn't sure whether this'd be an issue for you or him
[14:59] Cyberboss: its an issue for me, i guess i can just inflate the radius mdb renders by 1?
[14:59] Cyberboss: either way open an issue on the repo or ill forget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants