Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis pubsub disconnects in V3.1.0 #172

Open
AffectedArc07 opened this issue Apr 22, 2024 · 11 comments
Open

Redis pubsub disconnects in V3.1.0 #172

AffectedArc07 opened this issue Apr 22, 2024 · 11 comments
Labels
bug Something isn't working

Comments

@AffectedArc07
Copy link
Member

This now occurs when using 3.2.0, whereas in 3.0.0 it didn't

image-23-1.png

Reportedly occurs during high load procs such as round setup before start.

@ZeWaka
Copy link
Contributor

ZeWaka commented Apr 23, 2024

Could you test using 3.1.0 to see which release broke it? I don't recall any changes I've made that should've broke it - Goon runs 3.1.0 in production currently.

@ZeWaka
Copy link
Contributor

ZeWaka commented Apr 23, 2024

Maybe related to #173

@AffectedArc07
Copy link
Member Author

Maybe related to #173

Unsure, we're on windows.

@AffectedArc07
Copy link
Member Author

AffectedArc07 commented Apr 27, 2024

Disregard, didnt build right.

Testing when I can.

@AffectedArc07
Copy link
Member Author

Could you test using 3.1.0 to see which release broke it? I don't recall any changes I've made that should've broke it - Goon runs 3.1.0 in production currently.

@ZeWaka Confirmed also broken on 3.1.0

@ZeWaka ZeWaka changed the title Redis pubsub disconnects above V3.0.0 Redis pubsub disconnects in V3.1.0 May 8, 2024
@ZeWaka ZeWaka added the bug Something isn't working label Jun 1, 2024
@AffectedArc07
Copy link
Member Author

AffectedArc07 commented Nov 9, 2024

Update.

This broke on releases after 0.23.0 of the rust redis crate. Below is the content from Cargo.lock to allow it to work again.

[[package]]
name = "redis"
version = "0.23.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "3ea8c51b5dc1d8e5fd3350ec8167f464ec0995e79f2e90a075b63371500d557f"
dependencies = [
 "combine",
 "itoa",
 "percent-encoding",
 "ryu",
 "sha1_smol",
 "url",
]

We have a patch on our fork to counteract this, but a proper fix will be needed here sometime.

@optimumtact
Copy link
Member

What does redis say when it's disconnecting it?

@AffectedArc07
Copy link
Member Author

What does redis say when it's disconnecting it?

All these
image

@optimumtact
Copy link
Member

No I mean in the kern.log for the server, which is what is forcibly hanging up the connections.

@optimumtact
Copy link
Member

or the redis log of the server

@AffectedArc07
Copy link
Member Author

AffectedArc07 commented Nov 10, 2024

No I mean in the kern.log for the server, which is what is forcibly hanging up the connections.

Lemme dig

Edit - We dont have any

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants