Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a plan to remove the thanos- prefix from the user agent? #87

Open
ohkinozomu opened this issue Nov 13, 2023 · 1 comment · May be fixed by #88
Open

Is there a plan to remove the thanos- prefix from the user agent? #87

ohkinozomu opened this issue Nov 13, 2023 · 1 comment · May be fixed by #88

Comments

@ohkinozomu
Copy link

Some providers are currently adding a thanos- prefix to the user agent.

objstore/providers/gcs/gcs.go

Line 75 in 37752ee

option.WithUserAgent(fmt.Sprintf("thanos-%s/%s (%s)", component, version.Version, runtime.Version())),

objstore/providers/bos/bos.go

Line 92 in 37752ee

client.Config.UserAgent = fmt.Sprintf("thanos-%s", component)

objstore/providers/s3/s3.go

Line 275 in 37752ee

client.SetAppInfo(fmt.Sprintf("thanos-%s", component), fmt.Sprintf("%s (%s)", version.Version, runtime.Version()))

Is there a plan to remove this?

Related issue: #23
@metalmatze
Copy link
Contributor

I haven't heard anything about it. I also think you're the first person to ask.
I'm fine with removing it.

@ohkinozomu ohkinozomu linked a pull request Nov 13, 2023 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

breaking ⚠️ GCS,S3,BOS: Remove thanos- prefix from the user agent ohkinozomu/objstore
2 participants
@metalmatze @ohkinozomu