Add event connections to attendees types. #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otfix-comma Removes extraneous comma to prevent a silent PHP error.
bordoni
requested changes
Apr 9, 2021
includes/data/connection/class-wooattendee-connection-resolver.php
Outdated
Show resolved
Hide resolved
includes/data/connection/class-wooattendee-connection-resolver.php
Outdated
Show resolved
Hide resolved
includes/data/connection/class-wooattendee-connection-resolver.php
Outdated
Show resolved
Hide resolved
includes/data/connection/class-rsvpattendee-connection-resolver.php
Outdated
Show resolved
Hide resolved
includes/data/connection/class-paypalattendee-connection-resolver.php
Outdated
Show resolved
Hide resolved
includes/data/connection/class-paypalattendee-connection-resolver.php
Outdated
Show resolved
Hide resolved
…m/justlevine/ql-events into feature/attendee-event-connection
Co-authored-by: Gustavo Bordoni <[email protected]>
….php Co-authored-by: Gustavo Bordoni <[email protected]>
….php Co-authored-by: Gustavo Bordoni <[email protected]>
….php Co-authored-by: Gustavo Bordoni <[email protected]>
…r.php Co-authored-by: Gustavo Bordoni <[email protected]>
Co-authored-by: Gustavo Bordoni <[email protected]>
Co-authored-by: Gustavo Bordoni <[email protected]>
…ver.php Co-authored-by: Gustavo Bordoni <[email protected]>
Co-authored-by: Gustavo Bordoni <[email protected]>
…ver.php Co-authored-by: Gustavo Bordoni <[email protected]>
|
Requested changes merged. |
|
@justlevine @bordoni This functionality was implemented in #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds event connections to the various attendee types. Closes #24 .
Eventtype hasrSVPAttendees,payPalAttendees, andwooAttendees.rSVPAttendees,payPalAttendees, andwooAttendeescan now be filtered bywhere : { eventsIn: $id }.Note:
class-{type}attendee.phpandclass-{type}attendee-resolver.phpfiles were created for each attendee type. This isn't very DRY, but was the best I could do without fully changing attendee over to aninterface.class-attendee-resolver.phpwas never actually included before. There's a code segment from @kidunot89 that I left in, because I'm not really sure of the purpose/its effect. If it isn't necessary, it should be removed.composer dump-autoloadwas generatingplatform_check.php. I manually removed it, but to be safe, a maintainer should probably regenerate the autoload.