Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combustion Generator using ABM rather than Nodetimer? #16

Open
Beanzilla opened this issue Aug 10, 2022 · 1 comment
Open

Combustion Generator using ABM rather than Nodetimer? #16

Beanzilla opened this issue Aug 10, 2022 · 1 comment

Comments

@Beanzilla
Copy link

Is your feature request related to a problem? Please describe.
Why does the factory:combustion_generator use a ABM (Line 64) rather than a nodetimer?

Describe the solution you'd like
I feel the ABM works but so would using the nodetimer. (Just a dev looking at another persons code)

Describe alternatives you've considered
The only difference between the 2 is all factory:combustion_generators consume fuel and produce energy at the same time, where as the nodetimer would vary the energy as each fire at different times (since it would be almost impossible to place and activate them within a second).

Additional context
This is just a question, not an issue and/or really not even a feature request. (Just a dev looking at another persons code, that's all)

@theFox6
Copy link
Owner

theFox6 commented Sep 22, 2022

I used it because it was the default within the project and I didn't know much about nodetimers.
I think LemonLake used them because nodetimers weren't a thing back in the day.
Idk if ABMs ore nodetimers are more efficient, but I think producing energy at different times isn't much of a concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants