Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas datetime to timedelta conversion will now raise #685

Open
Casper-Guo opened this issue Feb 8, 2025 · 1 comment
Open

Pandas datetime to timedelta conversion will now raise #685

Casper-Guo opened this issue Feb 8, 2025 · 1 comment
Labels
maintenance Changes required to gurantee that things work properly in the future still
Milestone

Comments

@Casper-Guo
Copy link
Contributor

Casper-Guo commented Feb 8, 2025

Following our discussion in #674, Pandas is now changing the behavior to raising an error (ref: pandas-dev/pandas#60882).

I am guessing that we are relying on similar behaviors elsewhere in the code too and we should go through and fix them.

Update: Merged at pandas-dev/pandas#60882 and scheduled for release in Pandas v3.0.0

@theOehrly
Copy link
Owner

Given that this is merged, I think it is sufficient to run all tests locally with a nightly build of pandas. This will catch anything but weird edge cases (like the one in #674, I know...), but manually checking this seems like a lot of work.

@theOehrly theOehrly added this to the future milestone Feb 9, 2025
@theOehrly theOehrly added the maintenance Changes required to gurantee that things work properly in the future still label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes required to gurantee that things work properly in the future still
Projects
None yet
Development

No branches or pull requests

2 participants