From fb1ace2564c924343c1c6b861c2285d068906034 Mon Sep 17 00:00:00 2001 From: Rhodri Pugh Date: Mon, 28 Dec 2020 08:35:09 +0000 Subject: [PATCH 1/2] adds an interface for the client class --- src/Client.php | 6 +++--- src/GotenbergClientInterface.php | 20 ++++++++++++++++++++ 2 files changed, 23 insertions(+), 3 deletions(-) create mode 100644 src/GotenbergClientInterface.php diff --git a/src/Client.php b/src/Client.php index c7229a9..293c479 100644 --- a/src/Client.php +++ b/src/Client.php @@ -15,7 +15,7 @@ use function fopen; use function fwrite; -final class Client +final class Client implements GotenbergClientInterface { /** @var HttpClient */ private $client; @@ -30,7 +30,7 @@ public function __construct(string $apiURL, ?HttpClient $client = null) } /** - * Sends the given documents to the API and returns the response. + * {@inheritdoc} * * @throws ClientException * @throws Exception @@ -41,7 +41,7 @@ public function post(GotenbergRequestInterface $request): ResponseInterface } /** - * Sends the given documents to the API, stores the resulting PDF in the given destination. + * {@inheritdoc} * * @throws ClientException * @throws RequestException diff --git a/src/GotenbergClientInterface.php b/src/GotenbergClientInterface.php new file mode 100644 index 0000000..4289fda --- /dev/null +++ b/src/GotenbergClientInterface.php @@ -0,0 +1,20 @@ + Date: Wed, 30 Dec 2020 16:03:18 +0000 Subject: [PATCH 2/2] remove pull_request_target --- .github/workflows/continuous-integration.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 3e8e5ba..cd35c66 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -2,7 +2,6 @@ name: "Continuous Integration" on: pull_request: - pull_request_target: push: branches: - master