Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage navigation with KnpMenuBundle #55

Closed
netsensei opened this issue Feb 2, 2018 · 0 comments
Closed

Manage navigation with KnpMenuBundle #55

netsensei opened this issue Feb 2, 2018 · 0 comments

Comments

@netsensei
Copy link
Contributor

Detailed description

Right now, navigation is hard wired throughout different templates. The topnav.html.twig template contains presentation and business logic to render the menu. Depending on the context (logged in/ logged out) different menu items are shown. Then there are the sidebar menu items on "users", "clients" and "tokens".

The result is hard to understand code which is difficult to maintain.

We should move KnpMenuBundle for building and managing menu's.

Context

  • Separates business from presentational layer which improves maintainability vastly.
  • Introduces flexibility and room to expand how the menu tree is generated while adhering to the SOLID principles.

Possible implementation

Follow the implementation guide to start.

This issue currently depends on #50 which deprecates much of the SharedBundle folder and turns it into a dedicated CoreBundle instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant