Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color Recommendation Portal #51

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Color Recommendation Portal #51

merged 2 commits into from
Oct 6, 2023

Conversation

RajaVardhan-coder
Copy link
Contributor

Pull Request for Issue #30

Description

This pull request addresses issue #30, which involves the development of the [UI/Frontend] Color Recommendation Portal. Here are the key changes included in this PR:

  • Created an interactive web portal for users to input text.
  • Integrated the Flask backend to handle text input and generate color recommendations.
  • Designed a modern and colorful user interface with a gradient background.
  • Displayed recommended colors in square boxes below the input field.

harishankar1014
harishankar1014 suggested changes Oct 5, 2023
View reviewed changes
Copy link

@harishankar1014 harishankar1014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the form element of index.html you are doing an unnecessary post request as the JavaScript call is used to use the button as an event listener. You can remove the unnecessary call from the form to make the code cleaner.

harishankar1014
harishankar1014 approved these changes Oct 6, 2023
View reviewed changes
Copy link

@harishankar1014 harishankar1014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required changes were made (removed unnecessary attributes from form)

@ravi-prakash1907 ravi-prakash1907 merged commit 00e3038 into thedatatribune:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravi-prakash1907 ravi-prakash1907 ravi-prakash1907 approved these changes

@harishankar1014 harishankar1014 harishankar1014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RajaVardhan-coder @harishankar1014 @ravi-prakash1907