Did you ran your tests to be sure things are working?

I believe I ran the tests when I wrote the code, but it's been a while! I'll take a look tomorrow night to confirm.

On Wed, Jan 14, 2015 at 4:03 PM, Guilherme Oderdenge
[email protected] wrote:

Did you ran your tests to be sure things are working?

Reply to this email directly or view it on GitHub:
#230 (comment)

Yes, it's been a while man — sorry for that.

I'll be waiting your test-check and if passes well, we'll be merging this fix.

Thank you so far! 👍

I think I got everything reconfigured correctly. Looks like tests are passing for me:

Let me know if there's anything else I can do to help out.

@shipstar From my taking a quick look, the tests look good. That said, it seems there are merge issues. @chiefGui Can collaborators handle merge conflicts or should the pull request be updated?

@platinumazure If you want to update this PR, just fork from https://github.com/shipstar/backbone.validation and then create a new PR, this way you can reuse @shipstar's work.

@shipstar We need another update to be compatible with our latest release. If you want, you can do — but I think you're uninterested because you're not using Backbone.Validation anymore. Anyway, you should to know your PR is very useful for us. Thanks for now, man. 👍

Given that this PR is now 5 years old, I'm guessing it's far enough out of date that it shouldn't remain open. I'm going to close just to prune my PR list in GitHub, but I hope this was useful to someone else!