Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior of required attributes. #220

Open
Ky6uk opened this issue Mar 26, 2014 · 1 comment
Open

Incorrect behavior of required attributes. #220

Ky6uk opened this issue Mar 26, 2014 · 1 comment

Comments

@Ky6uk
Copy link

Ky6uk commented Mar 26, 2014

Current version of this library (0.9.1) uses _.intersection for comparison changed and invalidated attributes. But if no attribute defined in model, we have passing validation for this attribute despite of { required: true } rule.

@platinumazure
Copy link

Hi @Ky6uk,

First of all, can you confirm that this is still happening in the current version (v0.11.1)? (I assume it is since I remember seeing that _.intersection code, but it's still worth double-checking!)

Second, can you give us a test case? If you can give us an example of how to trigger this behavior, we can turn that into a unit test and that will help a lot in trying to fix this.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants