Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severe overweighting of RecDev penalty, fixed in 745a725 #28

Open
gavinfay opened this issue Oct 8, 2022 · 1 comment
Open

Severe overweighting of RecDev penalty, fixed in 745a725 #28

gavinfay opened this issue Oct 8, 2022 · 1 comment

Comments

@gavinfay
Copy link
Collaborator

gavinfay commented Oct 8, 2022

@sgaichas @MaC-Perez I had been puzzled at the large nLL for the recruitment penalties.

Turns out I was populating a vector of length Nrecdevs * Nspp with the SUM of the nLL for each recruitment deviation, and then summing those. e.g. effectively upweighting the recdevs by a factor of 400. Oops.
This is due to the version of dnorm() that gets called with a dvar_vector resid and a dvar_vector std.dev. (ie it returns the sum not the individual nLLs)

Fixed in commit 745a725. Sorry about this!
image

@sgaichas
Copy link
Collaborator

sgaichas commented Oct 9, 2022

interestingly, high weighting of RecDev penalties may may have been a good thing for the NOBA fits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants