add tests for inventory cache #1386
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
force-pushed
the
inventory-cache-tests
branch
from
27df53a to
14056df
Compare
evgeni
commented
Apr 22, 2022
Comment on lines
+9
to
+10
| - name: execute tests again, now fed from cache | ||
| include_tasks: inventory_plugin_tests.yml |
There was a problem hiding this comment.
this doesn't seem to work… I would expect the facts asserts to fail for the report api codepath, but they do not.
evgeni
force-pushed
the
inventory-cache-tests
branch
from
14056df to
15d22c7
Compare
evgeni
force-pushed
the
inventory-cache-tests
branch
from
15d22c7 to
7c4bb5f
Compare
it's deprecated and generates warnings
evgeni
commented
Apr 27, 2022
Comment on lines
+49
to
+50
| cache_content_host: "{{ (cache_slurp['content'] | b64decode | from_json).get('http://localhost:3000//api/v2/hosts/1') }}" | ||
| cache_content_facts: "{{ (cache_slurp['content'] | b64decode | from_json).get('http://localhost:3000//api/v2/hosts/1/facts') }}" |
There was a problem hiding this comment.
turns out, the host id is not strictly stable, fuck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes