Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move prprocessor to shared infrastructure #1679

Closed
2 of 3 tasks
ehelms opened this issue Nov 5, 2021 · 7 comments
Closed
2 of 3 tasks

Move prprocessor to shared infrastructure #1679

ehelms opened this issue Nov 5, 2021 · 7 comments
Assignees

Comments

@ehelms
Copy link
Member

ehelms commented Nov 5, 2021

The prprocessor project handles a number of tasks for the project and currently runs on @ekohl own infrastructure.

Options to move to:

Action Items

  • Move to Python 3.7
  • Move to one of the shared infrastructure environments
  • Make a post to discourse introducing Prprocessor to community again since it's been a while and new developers may not be familiar with it [@ekohl]
@ekohl
Copy link
Member

ekohl commented Apr 11, 2022

I've moved back to Python 3.7 (or really 3.8) compatibility (theforeman/prprocessor@d6eae43). Then I added compatibility with s2i (theforeman/prprocessor@1e6fa69) and documented (theforeman/prprocessor@4ec7fb4).

Now I've switched the URL (at https://github.com/organizations/theforeman/settings/apps/pr-processor) and it's serving from OpenShift. If there is a need to switch back, change the URL to https://prprocessor.ekohl.nl/ which I'll keep running for a while.

At least in theforeman/prprocessor#172 I verified that the webhook delivery works, though that doesn't call back to Redmine. However, it'd surprise me if that's broken.

Now I'll make a post on Discourse to announce the migration. With that I think we should monitor this for a week or so and then consider this resolved.

One thing I couldn't get working was triggering builds after a GitHub push. Probably better to open a new issue for that.

@ekohl
Copy link
Member

ekohl commented Apr 11, 2022

Oh, and running it on HTTPS instead of plain text HTTP. For now I've reverted to my instance.

@evgeni
Copy link
Member

evgeni commented Apr 14, 2022

I've added the following to the openshift route definintion:

  tls:
    termination: edge
    insecureEdgeTerminationPolicy: Redirect

and HTTPS works now.

@ekohl
Copy link
Member

ekohl commented Apr 14, 2022

Thanks for that! I switched the URL back to openshift and monitor it for a bit. Then I can make a Discourse post to announce it.

@evgeni
Copy link
Member

evgeni commented Apr 14, 2022

I've flipped the webhook in https://github.com/theforeman/prprocessor/settings/hooks from using the "github" hook URL in openshift, to the "generic" one, and now push events to the repo trigger new deployments.

(didn't have the motivation to debug why the github specific one didn't work)

@ekohl
Copy link
Member

ekohl commented Apr 14, 2022

I made an announcement here: https://community.theforeman.org/t/prprocessor-migrated-to-osci/28148

Perhaps the one item (do a more generic introduction) is still open, but it may be better to capture that in a new issue so we can close this one out.

@ekohl
Copy link
Member

ekohl commented Apr 14, 2022

I've opened #1733 and now consider this as done. Thanks @evgeni for fixing the 2 issues I didn't get around to.

I'll leave the instance on my personal infra running for a while. If there are issues, it should be easy to roll back.

@ekohl ekohl closed this as completed Apr 14, 2022
@ekohl ekohl moved this to Done in Infrastructure Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants