-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Katello entry points #421
base: develop
Are you sure you want to change the base?
Conversation
config/katello-answers.yaml
Outdated
--- | ||
certs: | ||
group: foreman | ||
katello: true | ||
global: true | ||
application: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The global and application naming conventions will be confusing to users and be incongruent with a base Foreman install. Could these two be combined into just the katello options from the users perspective?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we've dropped Pulp 2, it may be time to implement foreman::plugin::katello
. Not entirely sure yet, but we should take a look.
config/katello-answers.yaml
Outdated
global: true | ||
application: true | ||
pulp: true | ||
candlepin: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fits nicely with where the new certificate work is headed as it would allow users to configure the certificates if they wanted and set the defaults, e.g. https://github.com/theforeman/puppet-katello/pull/351/files#diff-0a129cc5a540f220caade2da4fc3229b
I think I've said it in some discussion, but I plan to revisit this once we've dropped Pulp 2. Refactoring those entry points is complicated and things will be much easier once we've dropped it. At that point I also want to take a critical looks at puppet-foreman_proxy_content. |
c15d2a7
to
7116fda
Compare
Depends on theforeman/puppet-katello#308.
This uses the separate classes in puppet-katello to expose in a more logical way to the end user.
The generated help text is below. Note that there's now
--candlepin-*
and--pulp-*
. The content types are--global-*
. With Pulp 3 these can be moved to--pulp-*
parameters but for Pulp 2 Katello 2 needs to be statically configured. There's qpid module with a rather advanced parameter. Currently Kafo can't hide a single parameter as advanced.