-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Candlepin pipeline to run puppet-candlepin tests #1712
Conversation
@ekohl How would you make https://github.com/theforeman/puppet-candlepin/blob/master/spec/setup_acceptance_node.pp#L20 configurable for running the beaker tests dynamically? I can imagine wanting to set:
|
I'm (mostly) happy with how puppet-pulpcore does it.
I'm unhappy with the last part: gha-puppet should have a way to do this without having to copy the whole workflow. My plan to solve that was to first get voxpupuli/puppet_metadata#35 done. That makes it possible to solve this TODO. Then we can consider ways to input those versions to CI. |
@ekohl Does this look good for a start? theforeman/puppet-candlepin#244 |
bd4db35
to
63e89ea
Compare
6747f3a
to
002a613
Compare
e098f4e
to
32fee10
Compare
32fee10
to
51c235f
Compare
@ehelms I moved a few things around, to make it even more re-useable, and overall I like it :) |
72f1369
to
d8ab376
Compare
ef05f8a
to
f04a440
Compare
This now relies on theforeman/puppet-candlepin#252 and relies upon two additional variables:
|
Can't we deduct the additional variables from the |
pipelines/candlepin/03-tests.yml
Outdated
beaker_puppet_module: "puppet-candlepin" | ||
beaker_os: "{{ pipeline_beaker_os }}" | ||
beaker_environment: | ||
BEAKER_FACTER_CANDLEPIN_BASEURL: "https://stagingyum.theforeman.org/candlepin/{{ pipeline_version }}/el{{ pipeline_beaker_os_version }}/x86_64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically, given this runs on the vagrant box, this could be
BEAKER_FACTER_CANDLEPIN_BASEURL: "https://stagingyum.theforeman.org/candlepin/{{ pipeline_version }}/el{{ pipeline_beaker_os_version }}/x86_64" | |
BEAKER_FACTER_CANDLEPIN_BASEURL: "https://stagingyum.theforeman.org/candlepin/{{ pipeline_version }}/el{{ ansible_distribution_major_version }}/x86_64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That won't work for testing EL8 and EL9 when the host itself is only EL8. That is why I felt these additional variables had to be introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I was working under the assumption we're keeping the current mode where we spin up a VM that matches the target OS.
I think I'm missing some bigger piece how this should be executed by automation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair, while not efficient, that is how this workflow works and we could keep that connection and assumption.
f04a440
to
08dc077
Compare
Starter test pipeline, this will require some changes to puppet-candlepin to allow configuring the repository to test. My goal is to provide this for theforeman/foreman-infra#1937 (comment)