Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"submit an issue" error message url encoding #955

Open
jbolda opened this issue Jul 27, 2021 · 1 comment
Open

"submit an issue" error message url encoding #955

jbolda opened this issue Jul 27, 2021 · 1 comment
Labels

Comments

@jbolda
Copy link
Contributor

jbolda commented Jul 27, 2021

The url is that is produced can contain single quotes which appear to break the link in some terminals. It would be nice to make it clickable.

image

Text shown in above screenshot:

It looks like you've encountered a bug in BigTest that triggered an unexpected
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
shutdown. And yes, in case you're wondering, this is definitely on us. It would
help us a lot to improve BigTest if you'd take the time to report the problem.

Submit an issue to the BigTest repository (​https://github.com/thefrontside/bigtest/issues/new?title=CRASH%3A%20Cannot%20set%20headers%20after%20they%20are%20sent%20to%20the%20client&labels=%F0%9F%90%9Bbug%2C%40bigtest%2Fcli&body=%0A%23%20Error%20Report%0A%0A%3E%20Please%20fill%20in%20your%20error%20report%20here%20with%20any%20details%20you%20think%20may%20be%20relevant%20to%20why%0A%3E%20the%20crash%20happened.%20Make%20sure%20to%20double%20check%20the%20diagnostic%20information%20to%20make%20sure%20that%0A%3E%20it%20doesn't%20contain%20anything%20that%20shouldn't%20be%20public.%0A%0A%3Cdetails%3E%3Csummary%3Ediagnostics%3C%2Fsummary%3E%0A%0AArgv%0A----%0Aci%2C-c%2Cbigtest.ci.json%0A%0AStack%0A-----%0AError%20%5BERR_HTTP_HEADERS_SENT%5D%3A%20Cannot%20set%20headers%20after%20they%20are%20sent%20to%20the%20client%0A%20%20%20%20at%20ServerResponse.setHeader%20(_http_outgoing.js%3A561%3A11)%0A%20%20%20%20at%20handleRequest%20(%2Fhome%2Frunner%2Fwork%2Ffrontside.com%2Ffrontside.com%2Fnode_modules%2F%40bigtest%2Fserver%2Fdist%2Fsrc%2Fproxy.js%3A19%3A17)%0A%20%20%20%20at%20handleRequest.next%20(%3Canonymous%3E)%0A%20%20%20%20at%20%2Fhome%2Frunner%2Fwork%2Ffrontside.com%2Ffrontside.com%2Fnode_modules%2Feffection%2Fdist%2Feffection.js%3A1%3A7739%0A%20%20%20%20at%20e.r.advance%20(%2Fhome%2Frunner%2Fwork%2Ffrontside.com%2Ffrontside.com%2Fnode_modules%2Feffection%2Fdist%2Feffection.js%3A1%3A7781)%0A%20%20%20%20at%20e.r.enter%20(%2Fhome%2Frunner%2Fwork%2Ffrontside.com%2Ffrontside.com%2Fnode_modules%2Feffection%2Fdist%2Feffection.js%3A1%3A7701)%0A%20%20%20%20at%20t.call%20(%2Fhome%2Frunner%2Fwork%2Ffrontside.com%2Ffrontside.com%2Fnode_modules%2Feffection%2Fdist%2Feffection.js%3A1%3A8325)%0A%20%20%20%20at%20t.n.enter%20(%2Fhome%2Frunner%2Fwork%2Ffrontside.com%2Ffrontside.com%2Fnode_modules%2Feffection%2Fdist%2Feffection.js%3A1%3A4576)%0A%20%20%20%20at%20e.n.fork%20(%2Fhome%2Frunner%2Fwork%2Ffrontside.com%2Ffrontside.com%2Fnode_modules%2Feffection%2Fdist%2Feffection.js%3A1%3A3943)%0A%20%20%20%20at%20e.r.advance%20(%2Fhome%2Frunner%2Fwork%2Ffrontside.com%2Ffrontside.com%2Fnode_modules%2Feffection%2Fdist%2Feffection.js%3A1%3A7849)%0A%0A%3C%2Fdetails%3E%0A​)
@cowboyd
Copy link
Member

cowboyd commented Jul 27, 2021

Grosss! It shourld be clickable for sure. We use terminal-link for generating the issue links. Maybe a bug there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants