Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AArch64 builds #46

Closed
mcgordonite opened this issue Jul 4, 2024 · 6 comments
Closed

Add AArch64 builds #46

mcgordonite opened this issue Jul 4, 2024 · 6 comments

Comments

@mcgordonite
Copy link
Contributor

It would be awesome to get AArch64 (arm64) support.

The package seems to work without modification when built on an arm64 Windows system. The challenge would be distribution for multiple platforms. The napi-rs docs suggest publishing multiple packages for this: https://napi.rs/docs/introduction/getting-started#deep-dive.

Would you be open to a PR?

@mcgordonite
Copy link
Contributor Author

Hi @cowboyd @jbolda @minkimcello, would you be open to a PR for this? Thanks!

@jbolda
Copy link
Collaborator

jbolda commented Jul 24, 2024

Thanks for the ping, missed this! We originally opted for a single package as it was only a single binary for a single platform. I would be happy to support a PR supporting ARM on Windows.

I agree that following the recommended napi approach would then be appropriate. We would be publishing 3 packages, the root ctrlc-windows and then an optional dep for each of x86 and arm64. Does that match your expectations?

@mcgordonite
Copy link
Contributor Author

That's right, there could be three packages: ctrlc-windows, ctrlc-windows-x64 and ctrlc-windows-arm64. I'll have a go at restructuring this repo along those lines and put up a PR.

@mcgordonite
Copy link
Contributor Author

@jbolda I found a simpler solution in the end, let me know what you think: #47

@mcgordonite
Copy link
Contributor Author

Thanks for merging my PR. Is it possible to do a release including the change?

@cowboyd
Copy link
Member

cowboyd commented Dec 24, 2024

@mcgordonite released! #49

@cowboyd cowboyd closed this as completed Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants