Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prebuilds for arm* architectures #190

Open
Apollon77 opened this issue Apr 20, 2024 · 9 comments
Open

Add prebuilds for arm* architectures #190

Apollon77 opened this issue Apr 20, 2024 · 9 comments

Comments

@Apollon77
Copy link
Contributor

A build on Raspi 4 takes 12 minutes, I did not tried Raspi 3 :-)

So yes adding the usual arm architectures (arm64, armv7, armv6) - maybe see relevant list from a noble repo at https://github.com/stoprocent/node-bluetooth-hci-socket/blob/main/.github/workflows/build.yml#L14 might be a good idea

@Apollon77
Copy link
Contributor Author

Ohh I see that it was started with https://github.com/thegecko/webbluetooth/pull/133/files already

@thegecko
Copy link
Owner

Ohh I see that it was started with https://github.com/thegecko/webbluetooth/pull/133/files already

Yeah, I couldn't get prebuildify to work with cmake-js which would prebuild a lot more binaries and include them with the package. Feel free to continue my work.

The setup on node-usb may help

@Apollon77
Copy link
Contributor Author

Apollon77 commented Apr 20, 2024

Ok, I had a look ... so in fact for prebuildify it would be needed to use own docker images or to add cmake to the "prebuild" docker images.
But this might not be enough because we might need also to allow adding custom package luke libudev-dev or such to the docker images dynamically ... thats then an even more interesting topic. I'm not deep in docker currently, so need to see if I jump on that topic ...

@thegecko
Copy link
Owner

I use custom docker images for node-usb, see: https://github.com/node-usb/docker-images.

Specifially: https://github.com/node-usb/docker-images/blob/main/linux-arm64/Dockerfile

@Apollon77
Copy link
Contributor Author

Would it make sense to add cmake there too to share those or do we need another repo for having cmake available? Then I could only provide them as "personal repo" unless you would like to add them here ...

@thegecko
Copy link
Owner

Hmm, we could add cmake there. If we need to split them in future, we can then worry about separate repos

@Apollon77
Copy link
Contributor Author

Do you want to do that or should I try to add a PR if I find time and get that tackled somehow? ;-) (my Docker knowledge is more limited :-)

@thegecko
Copy link
Owner

I have little time. Can you try to get a prebuild flow setup using those containers and we can add tools as needed.

@Apollon77
Copy link
Contributor Author

No promises currently. Also my time is limited and that task is far away from my comfort and knowledge zone tbh ... so I most likely will need a lot of time ... let's see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants