Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling extraction of dimension values with partial units #87

Open
kasei opened this issue Sep 30, 2019 · 2 comments
Open

Handling extraction of dimension values with partial units #87

kasei opened this issue Sep 30, 2019 · 2 comments
Assignees
@kasei @azaroth42

Comments

@kasei
Copy link
Collaborator

kasei commented Sep 30, 2019

The provenance sales data has many records where dimensions are specified using only partial units. For example, "3' 7 1/2 x 3' 2 1/2" (specifying feet but not inches). Should cromulent.extract.normalize_dimension be updated to handle these cases, assuming that the second value is in the same system (metric, imperial, French) but one unit finer than the previous?
kasei added a commit that referenced this issue Sep 30, 2019
@kasei
Improve cromulent.extract.normalize_dimension to handle values with o…
109538b 
…nly partial units (#87).
@kasei
Copy link
Collaborator Author

kasei commented Sep 30, 2019

109538b has a proof of concept for being more accepting of this style of dimension with only partial units.

@azaroth42
Copy link
Contributor

That seems good to me. I don't think there's any other interpretation possible.

@kasei kasei mentioned this issue Oct 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasei kasei

@azaroth42 azaroth42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kasei @azaroth42