You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on this PR:theislab/moscot#696 some notebooks failed because the PR currently sends error when an argument is ignored or when kwargs is given in kwargs=x but we would rather use **x form now.
because the kwargs argument will be removed in the future. However in this case it would still throw an error since callback_kwargs is an invalid argument (probably has to be xy_callback_kwargs). This means in the notebooks these kwargs were just ignored.
While working on this PR:theislab/moscot#696 some notebooks failed because the PR currently sends error when an argument is ignored or when kwargs is given in
kwargs=x
but we would rather use**x
form now.Take this code snippet for example
ideally instead of this we would use this
because the
kwargs
argument will be removed in the future. However in this case it would still throw an error sincecallback_kwargs
is an invalid argument (probably has to bexy_callback_kwargs
). This means in the notebooks these kwargs were just ignored.To see which cells of the notebooks failed you can check these test results
https://github.com/theislab/moscot/actions/runs/9488695422/job/26148224156?pr=696
ping: @ArinaDanilina @giovp @MUCDK
The text was updated successfully, but these errors were encountered: