Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax error on macOS High Sierra 10.13.6 #23

Open
asattelmaier opened this issue Dec 14, 2018 · 1 comment
Open

Syntax error on macOS High Sierra 10.13.6 #23

asattelmaier opened this issue Dec 14, 2018 · 1 comment

Comments

@asattelmaier
Copy link

Steps to reproduce:

  1. run bing-wallpaper.sh on terminal

Current behaviour:
Syntax Error Appears,

bing-wallpaper.sh: line 108: syntax error near unexpected token `<'
bing-wallpaper.sh: line 108: `read -ra urls < <(curl -sL $PROTO://www.bing.com | \'

Expected behaviour:
Downloading the images and display the downloaded images to the terminal.
@asattelmaier
Copy link
Author

I'm not that experienced in bash programming but this is a fix that works for me:
Line108 urls=$(curl -sL $PROTO://www.bing.com | \
Line114 archiveUrls=$(curl -sL "$PROTO://www.bing.com/HPImageArchive.aspx?format=js&n=$BOOST" | \

@nitrogear nitrogear mentioned this issue May 12, 2019
Open
thejandroman added a commit that referenced this issue Jan 18, 2022
@thejandroman
Update and simplify script
fc6034d 
After moving to Arch I decided to give this forgotten script a try. It didn't work. It was also very complicated. URL parsing from JSON is a crazy thing to try to do in a bash script. I don't have a Mac to test these changes on but hopefully everything still works. There were a number of overlapping PRs over the years that made it into this revision. I've tried to add credit to the original PRs where applicable.

Summary of changes:

1. Merge latest and boost code paths (From @Lyncredible in #39)
2. Use https for all requests if -s (From @Lyncredible in #39)
3. Update URL patterns  (From @Lyncredible in #39, @microdog in #36, @nitrogear in #23)
4. Add UHD support (fixes #43)
5. Remove contributing.json as it wasn't used anymore
@thejandroman thejandroman mentioned this issue Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asattelmaier