Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of Optional #55

Open
jmcintyre opened this issue Nov 12, 2024 · 2 comments
Open

Status of Optional #55

jmcintyre opened this issue Nov 12, 2024 · 2 comments

Comments

@jmcintyre
Copy link

I see the documentation listing optional as currently unsupported, but I was curious if there is any support at all for it. For example, do interfaces that use it not work at all, or would it be possible to retrieve the values without knowing if they were defaulted or passed across?

@jmcintyre
Copy link
Author

Looks like the generator gets confused on optional and outputs some invalid code. However, if I change that to output the same thing it would have done without the optional tag, then it appears to work alright. Would there be interest a change to that default behavior? It wouldn't be a complete implementation of optional (no function to check if the value was sent or defaulted), but it would process for those of us that that doesn't matter.

@jmcintyre
Copy link
Author

I put a pull request into the underlying generator project that does this: thejinchao/protoc-gen-turbolink#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant