Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3 upload timeout is not long enough #539

Open
jeff-knurek opened this issue Nov 9, 2022 · 1 comment
Open

s3 upload timeout is not long enough #539

jeff-knurek opened this issue Nov 9, 2022 · 1 comment
Labels
enhancement New feature or request help-wanted Issues in the state 'help-wanted' refactoring

Comments

@jeff-knurek
Copy link

jeff-knurek commented Nov 9, 2022

Project board link

It seems that there was an issue in the past about extending the retry for awscli commands: #181
And from that a change was merged in this PR: #346

However that value is hardcoded as 5. And while that amount of retries is suitable for most files, it still isn't enough for larger files (and or slow networks). Maybe the ideal solution is to allow MAX_UP_DOWN_LOAD_RETRIES to be set via env var, and then the user can decide what is appropriate for their cluster?

┆Issue is synchronized with this Jira Story by Unito

@adejanovski adejanovski added the new Issues requiring triage label Nov 9, 2022
@rzvoncek
Copy link
Contributor

rzvoncek commented Mar 5, 2024

Hi. This relates to #666. I agree we give more flexibility for the retry configuration.

@rzvoncek rzvoncek added refactoring and removed new Issues requiring triage to-groom labels Mar 5, 2024
@rzvoncek rzvoncek added enhancement New feature or request help wanted Extra attention is needed help-wanted Issues in the state 'help-wanted' and removed help wanted Extra attention is needed labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help-wanted Issues in the state 'help-wanted' refactoring
Projects
None yet
Development

No branches or pull requests

3 participants