Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete snapshot file after each successful upload #785

Open
1 task
adejanovski opened this issue Jun 18, 2024 · 0 comments
Open
1 task

Delete snapshot file after each successful upload #785

adejanovski opened this issue Jun 18, 2024 · 0 comments

Comments

@adejanovski
Copy link
Contributor

adejanovski commented Jun 18, 2024

Project board link

Following up on a suggestion made in #734, we could optimize disk space usage by deleting uploaded files as we go instead of clearing the whole snapshots at the end of the backup.
If backups take a long time to get uploaded, there's a chance sstables will get compacted and the corresponding snapshot file will get persisted to disk and potentially fill the disks.

Once a file is successfully uploaded, we have no need to keep it around because even in the case the backup fails, the snapshot will get cleared and a new one will get created for any subsequent backup.

Definition of Done

  • snapshot files are deleted right after successful upload, during the backup operation progress

┆Issue is synchronized with this Jira Story by Unito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant