Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP backups are failing if the storage class is unspecified #798

Closed
2 tasks
adejanovski opened this issue Aug 14, 2024 · 0 comments · Fixed by #800
Closed
2 tasks

GCP backups are failing if the storage class is unspecified #798

adejanovski opened this issue Aug 14, 2024 · 0 comments · Fixed by #800
Assignees
Labels
done Issues in the state 'done'

Comments

@adejanovski
Copy link
Contributor

adejanovski commented Aug 14, 2024

Project board link

We're missing a null check in the google storage implementation which makes the backups fail if the storage class isn't explicitly specified.

We instead should disable passing the storage class altogether since it's not supported by our gcp library underneath anyway.

In the Azure implementation, we need to add a null check and use the default storage class if it's not overridden.

Definition of Done

  • Storage class isn't used anymore in the google storage implementation
  • A null check is added to the Azure storage implementation before calling .upper() on it
@adejanovski adejanovski added the ready Issues in the state 'ready' label Aug 14, 2024
@adejanovski adejanovski added ready-for-review Issues in the state 'ready-for-review' and removed ready Issues in the state 'ready' labels Aug 14, 2024
@adejanovski adejanovski added done Issues in the state 'done' and removed ready-for-review Issues in the state 'ready-for-review' labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Issues in the state 'done'
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants