Automatically adding html, body tag on manifest, serviceworker files #840

gracefullight · 2019-04-17T13:30:41Z

I agree and want to create new issue

Yes, I was on Hexo Docs page, especially on Templates, Variables, Helpers and Troubleshooting.
Yes, I was on NexT Documentation Site.
And yes, I already searched for current issues and this is not help to me.

Expected behavior

localhost:4000/manifest.json

{
    "name": "Blog",
     ...
}

Actual behavior

localhost:4000/manfiest.json

<html><body>{ "name": "Blog" ... }</body></html>

Steps to reproduce the behavior

enable exturl: true (on /themes/next/_config.yml)
create manifest.json (on /source/manifest.json)
set favicon.android_manfiest /manifest.json (on /themes/next/_config.yml)

Link to demo site with this bug: N/A
Link(s) to source code or any usefull link(s):
Automatically adding <html><head><body> ? cheeriojs/cheerio#1031 (comment)

Node.js and NPM Information

v11.13.0
6.7.0

Package dependencies Information

{
  "name": "blog",
  "version": "1.0.0",
  "private": true,
  "hexo": {
    "version": "3.8.0"
  },
  "scripts": {
    "clean": "hexo clean && rimraf public/"
  },
  "dependencies": {
    "hexo": "^3.8.0",
    "hexo-all-minifier": "^0.5.3",
    "hexo-autonofollow": "^1.0.1",
    "hexo-deployer-git": "^1.0.0",
    "hexo-generator-amp": "^3.0.19",
    "hexo-generator-archive": "^0.1.5",
    "hexo-generator-category": "^0.1.3",
    "hexo-generator-feed": "^1.2.2",
    "hexo-generator-index": "^0.2.1",
    "hexo-generator-json-content": "^4.1.3",
    "hexo-generator-searchdb": "^1.0.8",
    "hexo-generator-seo-friendly-sitemap": "0.0.25",
    "hexo-generator-tag": "^0.2.0",
    "hexo-helper-qrcode": "^1.0.2",
    "hexo-renderer-ejs": "^0.3.1",
    "hexo-renderer-less": "^1.0.0",
    "hexo-renderer-markdown-it-plus": "^1.0.4",
    "hexo-renderer-stylus": "^0.3.3",
    "hexo-renderer-swig": "^1.1.0",
    "hexo-server": "^0.3.3",
    "hexo-symbols-count-time": "^0.4.4",
    "hexo-tag-leaflet": "^1.0.4",
    "workbox-cli": "^3.6.3"
  },
  "devDependencies": {
    "rimraf": "^2.6.3"
  }
}

Hexo Information

Hexo version

hexo: 3.8.0
hexo-cli: 1.1.0
os: Darwin 18.5.0 darwin x64
node: 11.13.0
v8: 7.0.276.38-node.18
uv: 1.27.0
zlib: 1.2.11
brotli: 1.0.7
ares: 1.15.0
modules: 67
nghttp2: 1.34.0
napi: 4
llhttp: 1.1.1
http_parser: 2.8.0
openssl: 1.1.1b
cldr: 34.0
icu: 63.1
tz: 2018e
unicode: 11.0

Hexo Configuration

NexT Information

NexT Version:

Latest Master branch
Latest Release version
Old version

NexT Scheme:

NexT Configuration:

Other Information

The text was updated successfully, but these errors were encountered:

welcome · 2019-04-17T13:30:46Z

Thanks for opening this issue, maintainers will get back to you as soon as possible!

jiangtj · 2019-04-17T15:26:29Z

You should config hexo _config.yml as following:

skip_render:
  - manfiest.json

gracefullight · 2019-04-17T15:31:40Z

@jiangtj Skip rendering other files? (like serviceworker..) How about adding xmlMode option?

jiangtj · 2019-04-17T15:33:55Z

xmlMode？What's it? 😂

gracefullight · 2019-04-17T15:37:51Z

@jiangtj I think this bug caused by cheerio

jiangtj · 2019-04-17T15:43:46Z

So? If disable exturl, it work well?

gracefullight · 2019-04-17T15:45:03Z

@jiangtj Yes, works fine.

jiangtj · 2019-04-17T15:51:47Z

Orz, may need modify exturl filter...
Like this https://github.com/hexojs/hexo-filter-lqip/blob/a31d8d732e60bc3da92c77dc26b5296bfdf9655b/lqip/index.js#L32-L47
Set hexo.route

GitHub
hexojs/hexo-filter-lqip
A Hexo plugins which helps to introduce low quality image placeholders to the theme - hexojs/hexo-filter-lqip

stevenjoezhang · 2019-04-27T03:08:11Z

I can’t reproduce this bug... exturl uses after_post_render filter, which should only work on html files, not json.

jiangtj · 2019-04-28T02:45:47Z

@stevenjoezhang Yes, it seems not wrapper with <html><body>. But it rendered files that is not .html suffix.

@gracefullight Can you test it with added this. And I don't know why your json file wrappered with <html><body>?

gracefullight · 2019-04-28T04:08:30Z

@stevenjoezhang yes, after_post_render is a hook for post only, but it's weird json files in that time.
(https://github.com/hexojs/hexo/blob/2ed17cd105768df379dad8bbbe4df30964fe8f2d/lib/hexo/post.js#L285)

I try to reproduce in this time, but it fails. 😨
If it happens again next time, I'll write more details.

Thanks for your time. @jiangtj

GitHub
hexojs/hexo
A fast, simple & powerful blog framework, powered by Node.js. - hexojs/hexo

stevenjoezhang · 2019-08-02T07:55:40Z

The loading of cheerio has been optimized in #1042. You can help to confirm whether the problem has been solved

stevenjoezhang · 2019-08-06T09:33:49Z

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automatically adding html, body tag on manifest, serviceworker files #840

Automatically adding html, body tag on manifest, serviceworker files #840

gracefullight commented Apr 17, 2019 •

edited

Loading

welcome bot commented Apr 17, 2019

jiangtj commented Apr 17, 2019

gracefullight commented Apr 17, 2019

jiangtj commented Apr 17, 2019

gracefullight commented Apr 17, 2019

jiangtj commented Apr 17, 2019

gracefullight commented Apr 17, 2019

jiangtj commented Apr 17, 2019 •

edited by unfurl-links bot

Loading

stevenjoezhang commented Apr 27, 2019

jiangtj commented Apr 28, 2019 •

edited

Loading

gracefullight commented Apr 28, 2019 •

edited by unfurl-links bot

Loading

stevenjoezhang commented Aug 2, 2019

stevenjoezhang commented Aug 6, 2019

Automatically adding html, body tag on manifest, serviceworker files #840

Automatically adding html, body tag on manifest, serviceworker files #840

Comments

gracefullight commented Apr 17, 2019 • edited Loading

I agree and want to create new issue

Expected behavior

Actual behavior

Steps to reproduce the behavior

Node.js and NPM Information

Package dependencies Information

Hexo Information

Hexo version

Hexo Configuration

NexT Information

NexT Configuration:

Other Information

welcome bot commented Apr 17, 2019

jiangtj commented Apr 17, 2019

gracefullight commented Apr 17, 2019

jiangtj commented Apr 17, 2019

gracefullight commented Apr 17, 2019

jiangtj commented Apr 17, 2019

gracefullight commented Apr 17, 2019

jiangtj commented Apr 17, 2019 • edited by unfurl-links bot Loading

stevenjoezhang commented Apr 27, 2019

jiangtj commented Apr 28, 2019 • edited Loading

gracefullight commented Apr 28, 2019 • edited by unfurl-links bot Loading

stevenjoezhang commented Aug 2, 2019

stevenjoezhang commented Aug 6, 2019

gracefullight commented Apr 17, 2019 •

edited

Loading

jiangtj commented Apr 17, 2019 •

edited by unfurl-links bot

Loading

jiangtj commented Apr 28, 2019 •

edited

Loading

gracefullight commented Apr 28, 2019 •

edited by unfurl-links bot

Loading