You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because we decided that adding baseline Gutenberg styles into theme was a good idea, we also need to take care of some baseline width, margin, padding, size, and similar values.
For example, take this code from resources/scss/blocks/core/_cover-image.scss:
As you can see, the content-width() function will return the theme's content width. However, we should take that further and allow theme authors to plug in other numeric values in /resources/scss/settings. The font-size, line-height and padding values from above could all be replaced with settings.
To do this, we'd need to identify all the places that could use such treatment and establish some standards on how to best handle that.
We could even explore existing packages/libraries that are out there.
The text was updated successfully, but these errors were encountered:
Because we decided that adding baseline Gutenberg styles into theme was a good idea, we also need to take care of some baseline width, margin, padding, size, and similar values.
For example, take this code from
resources/scss/blocks/core/_cover-image.scss
:As you can see, the
content-width()
function will return the theme's content width. However, we should take that further and allow theme authors to plug in other numeric values in/resources/scss/settings
. Thefont-size
,line-height
andpadding
values from above could all be replaced with settings.To do this, we'd need to identify all the places that could use such treatment and establish some standards on how to best handle that.
We could even explore existing packages/libraries that are out there.
The text was updated successfully, but these errors were encountered: