Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percent signs are stripped from titles #78

Open
armandn opened this issue Apr 16, 2019 · 3 comments
Open

Percent signs are stripped from titles #78

armandn opened this issue Apr 16, 2019 · 3 comments

Comments

@armandn
Copy link

armandn commented Apr 16, 2019

If a title contains a percent sign, e.g. "Nasdaq up 25%", the "%" is stripped from the title (only in posts archives, single titles are OK).

It looks like the problem is in functions-post.php, in render_permalink(): there's this code:

	$html = sprintf(
		'<a class="%s" href="%s">%s</a>',
		esc_attr( $args['class'] ),
		esc_url( $url ),
		sprintf( $args['text'], esc_url( $url ) )
	);

I don't understand the purpose of sprintf( $args['text'], esc_url( $url ) ), but replacing it with just $args['text'] seems to fix the problem.

@justintadlock
Copy link
Member

Are you posting in the right repository?

Is this something in Hybrid Core? https://github.com/justintadlock/hybrid-core

@armandn
Copy link
Author

armandn commented Apr 16, 2019

Yes, sorry, it's Hybrid Core. I forgot that under the hood Mythic uses Hybrid Core that has a separate repo.

@armandn
Copy link
Author

armandn commented Apr 19, 2019

Do you want me to post the issue on Hybrid Core and close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants