Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG system #9

Open
samikeijonen opened this issue Mar 5, 2018 · 1 comment
Open

SVG system #9

samikeijonen opened this issue Mar 5, 2018 · 1 comment
Labels
Component: App Enhancement New feature or request. Maybe Later

Comments

@samikeijonen
Copy link
Collaborator

SVG system may or may not be good fit for this project. If you ask me, it is:) I can't remember the last time when SVGs wasn't involved in a project.

What SVG system can mean:

  • get_svg() function or similar to injecting SVG icon markup in the template files.
  • Social menu links using SVG icons.
  • Build tools that minify SVG icons into single SVG sprite file.
  • Example file in Foxer.
@justintadlock
Copy link
Member

Based on what we've previously tested and the current WordPress.org rules, I'm marking this as something to consider later. I don't think it'll happen by a 1.0 release.

file_get_contents() is pretty much a requirement for what you have in mind, so this Theme Check ticket would need to be addressed: WordPress/theme-check#55

I'm still not 100% sold on that being the best method. Essentially, I want to test out some different ideas in real-world projects before committing to any one direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: App Enhancement New feature or request. Maybe Later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justintadlock @samikeijonen