Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect toggling of custom classes in accordions #1005

Open
AngeloKarugo opened this issue Dec 10, 2024 · 0 comments · May be fixed by #1006
Open

Incorrect toggling of custom classes in accordions #1005

AngeloKarugo opened this issue Dec 10, 2024 · 0 comments · May be fixed by #1006

Comments

@AngeloKarugo
Copy link

AngeloKarugo commented Dec 10, 2024

When an accordion item is expanded, classes in data-active-classes are removed if they are also present in data-inactive-classes. This is a problem when you want the same classes applied for both when the accordion is open & and when it's closed.

Steps to reproduce:

  1. Add an accordion component from the docs
  2. Set data-active-classes="foo bar foobar" and data-inactive-classes="foo bar barfoo" on the accordion container element
  3. Toggle the accordion
  4. Classes foo and bar are removed from the accordion toggle

Expected behavior
All classes in data-active-classes should be present when the accordion is open and all classes in data-inactive-classes should be present when the accordion is closed.

@AngeloKarugo AngeloKarugo linked a pull request Dec 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant