Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: define file name for cover #43

Open
roberto-butti opened this issue Sep 20, 2021 · 0 comments · May be fixed by #44
Open

[Feature Request]: define file name for cover #43

roberto-butti opened this issue Sep 20, 2021 · 0 comments · May be fixed by #44

Comments

@roberto-butti
Copy link

roberto-butti commented Sep 20, 2021

In order to load jpg file and png file as cover, make asset/cover.jpg configurable.

My proposal is to add image in config['cover']['image']

    /**
     * Cover photo position and dimensions
     */
    'cover' => [
        'position' => 'position: absolute; left:0; right: 0; top: -.2; bottom: 0;',
        'dimensions' => 'width: 210mm; height: 297mm; margin: 0;',
        'image' => 'cover.png',
    ],

Then, replace cover.jpg with the content of ['cover']['image'].
Remember to Update the stub/ibis.php file

I'm going to create a PR

@roberto-butti roberto-butti linked a pull request Sep 20, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant