Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal ua styles for tabs #44

Open
bkardell opened this issue Dec 29, 2020 · 0 comments
Open

minimal ua styles for tabs #44

bkardell opened this issue Dec 29, 2020 · 0 comments

Comments

@bkardell
Copy link

We currently are inferring things about layout for tabs, but then do nothing at all beyond that. From my own experience with them just now and from the demo, it would appear to me that we should at least provide a default margin-right or something to separate the tabs, else the headings text just run together (you can see this in the demo page). It also seems that something minimal to indicate the selected tab is actually necessary as well. Could be a background color or simple bottom shadow or something.

I have my own thoughts on how to best to try this, but @jonathantneal often is pretty good with matching expectations and I'm curious to hear how he would add UA styles for this so it doesn't screw up some other expectation - he has pretty good intuition/ideas here I think.

/ @davatron5000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant