Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patcher: clarify options UI #427

Open
RDIL opened this issue Apr 14, 2024 · 1 comment
Open

Patcher: clarify options UI #427

RDIL opened this issue Apr 14, 2024 · 1 comment
Labels
new feature Addition of a new feature, or request for a new feature. patcher Issues or pull requests targeting the patcher.

Comments

@RDIL
Copy link
Member

RDIL commented Apr 14, 2024

What
We should add something that explains all the patcher options - could be either a documentation page, or some kind of tooltip in the patcher itself (e.g. one of those ? circles you hover over next to each option that says what they do.)

Why
Right now, users can change options without knowing what they do, namely turning off the HTTP patch without knowing it will break the server unless they manually setup SSL.

@RDIL RDIL added the new feature Addition of a new feature, or request for a new feature. label Apr 14, 2024
@RDIL RDIL moved this to Todo in Patcher Product Roadmap Apr 14, 2024
@RDIL RDIL added the patcher Issues or pull requests targeting the patcher. label Apr 14, 2024
@grappigegovert
Copy link
Member

While that's not a bad idea, I think we should remove the option for turning off the http patch altogether.
The only situation in which this would cause problems is when trying to connect to a server that supports https, but not http. I don't think such a server exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Addition of a new feature, or request for a new feature. patcher Issues or pull requests targeting the patcher.
Projects
Development

No branches or pull requests

2 participants