Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hokkaido Snow Festival missing on h2 #505

Closed
suanjiansalt opened this issue Aug 11, 2024 · 2 comments · Fixed by #550
Closed

Hokkaido Snow Festival missing on h2 #505

suanjiansalt opened this issue Aug 11, 2024 · 2 comments · Fixed by #550
Labels
bug Something isn't working! h2 Related to HITMAN 2 ui Related to the game's menus.

Comments

@suanjiansalt
Copy link
Contributor

suanjiansalt commented Aug 11, 2024 •
edited
Loading

Describe the bug
It's not visible on the Hokkaido destination. Might linked to that location LOCATION_HOKKAIDO_MAMUSHI (or LOCATION_HOKKAIDO_SHIM_MAMUSHI) missing in early versions.

Its escalations will not be deployed, too.
@suanjiansalt suanjiansalt added bug Something isn't working! ui Related to the game's menus. h2 Related to HITMAN 2 labels Aug 11, 2024
@AnthonyFuller AnthonyFuller mentioned this issue Aug 11, 2024
Closed
@thecatontheceiling
Copy link
Contributor

Still unfixed?

@AnthonyFuller
Copy link
Contributor

Correct. It can only be fixed in v8.

AnthonyFuller added a commit that referenced this issue Jan 4, 2025
@AnthonyFuller
refactor: game versioned missionsInLocations and fix certain contract…
3bfe2ba 
…s when resolved

Fixes #510 #505 #504
@AnthonyFuller AnthonyFuller mentioned this issue Jan 4, 2025
Merged
@AnthonyFuller AnthonyFuller linked a pull request Jan 4, 2025 that will close this issue
refactor!: game versioned missionsInLocation, fix certain contracts when resolved, rename missionsInLocations -> missionsInLocation #550
Merged
RDIL added a commit that referenced this issue Jan 15, 2025
@RDIL
refactor!: game versioned missionsInLocation, fix certain contracts w…
17ba3ea 
…hen resolved, rename missionsInLocations -> missionsInLocation (#550)

Fixes #510 #505 #504

Needs testing and checking over more than twice.

## Breaking Changes
- `controller.missionsInLocations` is now
`controller.missionsInLocation` (as it always should have been!).
- The aforementioned `controller.missionsInLocations` is now **split by
game version**.
- `controller.addEscalation` has a new parameter: `(groupContract,
locationId, **gameVersion**, ...levels)` (highlighted using asterisks).

---

Also this removes some terrible hacks we've had to do. We should've
always done it like this!
@RDIL RDIL closed this as completed in #550 Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working! h2 Related to HITMAN 2 ui Related to the game's menus.
Projects
None yet
Milestone
No milestone
3 participants
@AnthonyFuller @thecatontheceiling @suanjiansalt